Skip to content

Update algolia search docs with vendors#119

Merged
ivan-nginx merged 4 commits intotheme-next:masterfrom
sli1989:algolia-search
Feb 8, 2018
Merged

Update algolia search docs with vendors#119
ivan-nginx merged 4 commits intotheme-next:masterfrom
sli1989:algolia-search

Conversation

@sli1989
Copy link
Collaborator

@sli1989 sli1989 commented Feb 6, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): N/A

What is the new behavior?

Add 3rd module installation instructions and CDN vendors support,

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@sli1989
Copy link
Collaborator Author

sli1989 commented Feb 7, 2018 •
edited
Loading

Need more fix using CDN. I am working on it.

@sli1989
Copy link
Collaborator Author

sli1989 commented Feb 7, 2018

how to remove

<svg xmlns="http://www.w3.org/2000/svg" id="sbx-icon-search-13" viewBox="0 0 40 40" width="100%" height="100%">
    <path d="M26.804 29.01c-2.832 2.34-6.465 3.746-10.426 3.746C7.333 32.756 0 25.424 0 16.378 0 7.333 7.333 0 16.378 0c9.046 0 16.378 7.333 16.378 16.378 0 3.96-1.406 7.594-3.746 10.426l10.534 10.534c.607.607.61 1.59-.004 2.202-.61.61-1.597.61-2.202.004L26.804 29.01zm-10.426.627c7.323 0 13.26-5.936 13.26-13.26 0-7.32-5.937-13.257-13.26-13.257C9.056 3.12 3.12 9.056 3.12 16.378c0 7.323 5.936 13.26 13.258 13.26z" fill-rule="evenodd">
    </path>
  </svg>

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20" width="100%" height="100%">
    <path d="M8.114 10L.944 2.83 0 1.885 1.886 0l.943.943L10 8.113l7.17-7.17.944-.943L20 1.886l-.943.943-7.17 7.17 7.17 7.17.943.944L18.114 20l-.943-.943-7.17-7.17-7.17 7.17-.944.943L0 18.114l.943-.943L8.113 10z" fill-rule="evenodd">
    </path>
  </svg>

@ivan-nginx
Copy link
Member

ivan-nginx commented Feb 7, 2018

So, mb in pull this changes?

@sli1989
Copy link
Collaborator Author

sli1989 commented Feb 7, 2018

Fixed already. Review required.

sli1989
sli1989 commented Feb 8, 2018
View reviewed changes
docs/ALGOLIA-SEARCH.md Outdated
```

```
// Custom styles.
Copy link
Collaborator Author

@sli1989 sli1989 Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

.ais-search-box--magnifier svg {
    display: none !important;
}

It seems they are all working. But I don't know how to choose one.

Copy link
Collaborator Author

@sli1989 sli1989 Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. The PR is right.

Copy link
Member

@ivan-nginx ivan-nginx Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sli1989 so, maybe u can add this to lib plugin?

Copy link
Member

@ivan-nginx ivan-nginx Feb 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, wait. This need just add to algolia styles in NexT i think.

Copy link
Collaborator Author

@sli1989 sli1989 Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, working on it.

Copy link
Collaborator Author

@sli1989 sli1989 Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emm, i will try it.

@sli1989
Copy link
Collaborator Author

sli1989 commented Feb 8, 2018

FIXED in third-party/algolia-search.styl.

ivan-nginx
ivan-nginx approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah, good job!

@ivan-nginx ivan-nginx merged commit 9b155fc into theme-next:master Feb 8, 2018
@ivan-nginx ivan-nginx added this to the v6.0.4 milestone Feb 8, 2018
@sli1989 sli1989 deleted the algolia-search branch February 8, 2018 05:05
@sli1989 sli1989 mentioned this pull request Mar 15, 2018
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@ivan-nginx
Merge pull request theme-next#119 from sli1989/algolia-search
b1362d7 
Update algolia search docs with vendors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

Assignees

No one assigned

Labels

📖 Docs

Projects

None yet

Milestone

v6.0.4

Development

Successfully merging this pull request may close these issues.

3 participants

@sli1989 @ivan-nginx @stevenjoezhang